NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
56 stars 118 forks source link

HAILCAST bug fix (units issue) #320

Closed jaymes-kenyon closed 8 months ago

jaymes-kenyon commented 8 months ago

Description

This corrects a units issue in the HAILCAST diagnostic code. Prior to this fix, the diagnosed hail diameter was labeled in millimeters, but the calculated values (in the output) were actually in meters. This created the perception of very small hail, often just a fraction of a millimeter. The corrected code yields hail diameter in millimeters. Thanks to @adams-selin (HAILCAST developer) for the troubleshooting assistance and the bug fix.

How Has This Been Tested?

This modification has been tested on Hera in a 36-h RRFS retrospective case (CONUS domain). As expected, the diagnosed hail diameters are simply increased by a factor of 1000. As an example, a screenshot is attached of the "hailcast_dhail" array: previous values are shown at left, with updated (corrected) values on the right.

hail

Checklist:

Please check all whether they apply or not

MatthewPyle-NOAA commented 8 months ago

@junwang-noaa Could you help move this one along? Is fixing an issue for RRFS. Thanks!

junwang-noaa commented 8 months ago

@bensonr would you please commit the PR? Thanks