Address compiler warnings for FV3 raised in an issue

bensonr commented 6 months ago

Fixes the compiler warnings in fv_regional_bc.F90, test_cases.F90, and module_diag_hailcast.F90 as identified by NCO. Unfortunately the logic in fv_nudge.F90 is too complex to easily address the goto identified herein.

Fixes #307

How Has This Been Tested?

No tests have yet been run. I will ask the relevant EPIC team members to test when ready.

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

DusanJovic-NOAA commented 6 months ago

Please remove -nowarn compiler flag from cmake/compiler_flags_Intel_Fortran.cmake

bensonr commented 6 months ago

@DusanJovic-NOAA - compiler flag update completed and typo fixed in test_cases.F90

XiaqiongZhou-NOAA commented 6 months ago

I see the commit to solve the same issue in AQM production branch: https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere/commit/d334488031c7378bf76a677dede0ded2035f8777

DusanJovic-NOAA commented 5 months ago

ufs-weather-model regression test passed, see https://github.com/ufs-community/ufs-weather-model/pull/2218

bensonr commented 5 months ago

@DusanJovic-NOAA - I just merged the top of the dev/emc trunk to ensure any testing contains the updates from PR #320

DusanJovic-NOAA commented 5 months ago

@bensonr Please sync this branch with dev/emc.

bensonr commented 5 months ago

@DusanJovic-NOAA - should be done, but please check to ensure.

DusanJovic-NOAA commented 5 months ago

@DusanJovic-NOAA - should be done, but please check to ensure.

Thanks, looks good.

NOAA-GFDL / GFDL_atmos_cubed_sphere

Address compiler warnings for FV3 raised in an issue #324