Remove -DUSE_COND and -DMOIST_CAPPA for hydrostatic runs

NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code

Other

56 stars 118 forks source link

Remove -DUSE_COND and -DMOIST_CAPPA for hydrostatic runs #337

Closed XiaqiongZhou-NOAA closed 5 months ago

XiaqiongZhou-NOAA commented 6 months ago

Description

The compiling flags -DUSE_COND and -DMOIST_CAPPA are removed for hydrostatic runs.

Fixes # (issue)

How Has This Been Tested?

It was tested on Hera with intel and gnu. A regression test with hydrostatic options is added in UFS. Related PRs:

https://github.com/NOAA-EMC/fv3atm/pull/828 https://github.com/ufs-community/ufs-weather-model/pull/2255

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

lharris4 commented 6 months ago

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

XiaqiongZhou-NOAA commented 6 months ago

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

Hi, @XiaqiongZhou-NOAA . This only changes the compilation and not any code, correct?

yes.

yangfanglin commented 6 months ago

@lharris4 Lucas, when the change from a compile-time option to a runtime option be ready ? We'd like to start using the hydro option for SFS development as soon as possible. Can Kate still commit this minor change while your team works on the namelist option ?

lharris4 commented 6 months ago

Hi, Fanglin. We haven't started working on this yet as we have been busy with other tasks. Indeed for now Kate's revision is the right solution.

Thanks Lucas

On Fri, Apr 26, 2024 at 10:31 AM Fanglin Yang @.***> wrote:

@lharris4 https://github.com/lharris4 Lucas, when the change from a compile-time option to a runtime option be ready ? We'd like to start using the hydro option for SFS development as soon as possible. Can Kate still commit this minor change while your team works on the namelist option ?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/337#issuecomment-2079512674, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVH4YYDESOOERSBLWVTY7JQM7AVCNFSM6AAAAABG24FW4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGUYTENRXGQ . You are receiving this because you were mentioned.Message ID: @.***>

junwang-noaa commented 6 months ago

@XiaqiongZhou-NOAA how urgent do you need to commit the changes in? We need to coordinate with EPIC to get this committed and updated in UFS weather model.

XiaqiongZhou-NOAA commented 6 months ago

@XiaqiongZhou-NOAA how urgent do you need to commit the changes in? We need to coordinate with EPIC to get this committed and updated in UFS weather model.

@junwang-noaa I consider it as "Normal". I also created related PRs in UFS. This change will not impact other runs, only change the result when -DHYDRO=ON.

zach1221 commented 5 months ago

Regression Testing is finished on WM PR #2255. @bensonr can you please merge this cubed sphere PR?