Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90 - Githubissues

NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code

Other

56 stars 118 forks source link

Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90 #338

Closed climbfuji closed 3 months ago

climbfuji commented 4 months ago

Description

All in the title. Required for supporting optional arguments in CCPP (see https://github.com/ufs-community/ufs-weather-model/pull/2205 and PRs listed there).

Working towards https://github.com/NCAR/ccpp-framework/issues/540

This is part of a large set of PRs:

https://github.com/NCAR/ccpp-framework/pull/552 https://github.com/NOAA-EMC/fv3atm/pull/807 https://github.com/ufs-community/ufs-weather-model/pull/2205 https://github.com/ufs-community/ccpp-physics/pull/189 https://github.com/NCAR/ccpp-framework/pull/556 (can be scheduled and merged anytime beforehand) https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/338 https://github.com/NOAA-PSL/stochastic_physics/pull/79

How Has This Been Tested?

ufs-weather-model full regression testing on Hera (all tests b4b)

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

climbfuji commented 4 months ago

@bensonr This complicated PR is finally open for review

FernandoAndrade-NOAA commented 3 months ago

Testing for #2205 has completed successfully, please continue with merging this PR.