Cherry pick to add an option to calculate omega in non-hydrostatic runs similar to hydrostatic method

XiaqiongZhou-NOAA commented 3 months ago

Description This update cherry-picks from Release 042022 (https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/pull/184). A new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode, has been added. When set to true, the omega calculation will match that of hydrostatic runs, using the formula omega = dp/dt. The default value is false, where the calculation remains omega = w * dp/dz as before.

How Has This Been Tested?

This update is tested on Hercules with both intel and gnu compiler and all UFS regression tests produced identical results with default setting.

Checklist:

Please check all whether they apply or not

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

zach1221 commented 2 months ago

@laurenchilutti testing is complete on WM PR#2327. Please feel free to merge this cubed-sphere PR. @FernandoAndrade-NOAA

zach1221 commented 2 months ago

Copying @bensonr as well. Rusty, if you're able to merge, this PR is ready.

NOAA-GFDL / GFDL_atmos_cubed_sphere

Cherry pick to add an option to calculate omega in non-hydrostatic runs similar to hydrostatic method #344