NOAA-GFDL / GFDL_atmos_cubed_sphere

The GFDL atmos_cubed_sphere dynamical core code
Other
56 stars 118 forks source link

STY: Use mbar and Pa for units of pressure #356

Open DWesl opened 1 month ago

DWesl commented 1 month ago

Description

Fixes https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/issues/350 by using Pa instead of pa and mbar instead of mb as units of pressure. This should make the units of pressure generated by this repository machine-readable. https://github.com/NOAA-EMC/fv3atm/pull/859 makes other units machine-readable

Replaces #355

How Has This Been Tested?

I made similar changes to a version of this repository in global-workflow, which I then compiled and ran. This produced netCDF history files with machine-readable units (specifically the python pint program, though I also checked with UDUnits).

Checklist:

Please check all whether they apply or not

laurenchilutti commented 3 weeks ago

Can you please resolve the conflicts in the file driver/fvGFS/fv_nggps_diag.F90? I think all you will need to do is merge the dev/emc branch into your sty-units-fixes branch and resolve the conflicts from there.