"save_pp_data" flag doesn't delete data if a plot fails

[jtmims]

Bug Severity

• [x] 1 = Minor problem that does not affect total framework functionality (e.g., computation error in a POD, problem with logging output, or an issue on a single system
• [ ] 2 = Major problem that affects overall functionality, but that does not occur for all users (e.g., problems installing the framework with a specific Conda version, a framework option that causes one or more PODs to fail, or missing/incompatible Python modules).
• [ ] 3 = Catastrophic problem that occurs frequently for multiple users and/or on multiple systems (e.g.,framework consistently fails to install on multiple systems, or one or more PODs continuously fails after running successfully)

Describe the bug Currently, the "save_pp_data" flag in the runtime_config json file doesn't matter if the POD has a faulty plot for PODs such as Wheeler_Kiladis or MJO_suite. Since we are trying to implement the MDTF into the workflow of GFDL model development, having lingering pp_data in dirs could become problematic especially when wanting to run a large suite of PODs.

Environment Describe the system environment:

• OS: RHEL 8
• Conda version: 24.7.1

[jtmims]

After digging further into output_manager.py, it seems as though the framework was agnostic to the files in the WORK_DIR and would only cleanup .nc files in each POD dir. #710 makes the framework look into the WORK_DIR/OUTPUT_DIR as well.