search

NOAA-GFDL / MOM6

Modular Ocean Model
Other
27 stars 60 forks source link

Inline harmonic analysis #719

Open c2xu opened 2 months ago

c2xu commented 2 months ago
  1. Currently, the harmonic analysis does not have the restart capability to span multiple run segments.
  2. Array indexing should be more consistent with that in the model, e.g., using hor_index_type to specify the dimensions.
  3. The use of harmonic analysis should be specified by a logic flag, instead of relying on parameters inside the module.
  4. Revisit the use of local variable instead of pointer for the control structure.
c2xu commented 2 months ago
  1. The subroutine HA_init is called from the subroutine tidal_forcing_init, but it seems that in regional models tides can be forced from open boundaries only without enabling astronomical tidal forcing.
c2xu commented 3 weeks ago
  1. Right now only one accumulator of FtF is implemented (at each baroclinic time step) and is shared between all FtSSH. This would become problematic if some FtSSH is accumulated at different time steps (e.g., the barotropic time step).
  2. Also, the harmonic analysis doesn't really need such a high temporal resolution. Instead of each baroclinic time step, they can be called at, e.g., each hour. It might be more convenient to have a user-specified sampling frequency.