Description
The Translate Test needs a lot of love. The first step is to make sure no code lives outside of ndsl that should be back to the mothership. This pulls pyFV3 and pySHiELD code that should not be there.
⚠️ pyFV3 and pySHiELD will break and need to be adapted. Namely there conftest needs to import ndsl.conftest⚠️
Other change to allow for an easier "from scratch" experience for testing are:
--dperiodic is removed, replaced with a --layout option with cube and tile as values to describe which grid the test needs
--compute_grid is removed and extended by --grid option with file (default), compute (replaces --compute_grid and default which allows to run a test with no Grid-Info.nc present on a simple npx/npy/npz grid with no metric terms
The script to turn serialbox .dat to netcdf is now in ndsl and available on the command line with ndsl-serialbox_to_netcdf
How Has This Been Tested?
This comes around as we are building 101 notebooks. In the series, we are showing how to port Fortran code and are making a translate test from scratch, which prompted and tested those changes.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
Description The Translate Test needs a lot of love. The first step is to make sure no code lives outside of
ndslthat should be back to the mothership. This pullspyFV3andpySHiELDcode that should not be there.⚠️
pyFV3andpySHiELDwill break and need to be adapted. Namely thereconftestneeds to importndsl.conftest⚠️Other change to allow for an easier "from scratch" experience for testing are:
--dperiodicis removed, replaced with a--layoutoption withcubeandtileas values to describe which grid the test needs--compute_gridis removed and extended by--gridoption withfile(default),compute(replaces--compute_gridanddefaultwhich allows to run a test with noGrid-Info.ncpresent on a simplenpx/npy/npzgrid with no metric terms.dattonetcdfis now inndsland available on the command line withndsl-serialbox_to_netcdfHow Has This Been Tested? This comes around as we are building 101 notebooks. In the series, we are showing how to port Fortran code and are making a translate test from scratch, which prompted and tested those changes.
Checklist: