Changes to test configurations options and externals for parsing - Githubissues

NOAA-GFDL / NDSL

NOAA NASA Domain Specific Language middleware layer

6 stars 8 forks source link

Changes to test configurations options and externals for parsing #53

Closed fmalatino closed 2 months ago

fmalatino commented 3 months ago

Description Conditional statement in stencils/testing/test_translate.py changed to check for compute passed via the --grid pytest option.

Switched conditional statement in ndsl/stencils/testing/conftest.py to check for option of cubed-sphere selection

Made mysign parameter of fill_corners_dgrid_defn an external variable

Resolves Issue 52

How Has This Been Tested? Tested in pyFV3 and pySHiELD translate tests github workflow.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules
[x] New check tests, if applicable, are included

fmalatino commented 2 months ago

LGTM. Can you put an issue in PyFV3 to propagate the change to fill_corners_dgrid_defn there once this is merged?

@oelbert those changes should be currently in PR 23, which is still in draft as it is dependent on this PR.