NOAA-GFDL / NDSL

NOAA NASA Domain Specific Language middleware layer
6 stars 8 forks source link

fix the mysign symbol missing bug in python 3.11 #60

Closed xyuan closed 1 month ago

xyuan commented 1 month ago

Description This PR fix the python 3.11 runtime bugs caused by the node visitor transverse depth limitation, it crashed as missing symbol error during runtime.

This is caused by the optimization pass for oir and dace sdfg, which removes the "unused" symbol, because the limitation of node visitor transver depth limitation. This issue appeared in the dace backend with and without orchestration option.

Fixes # (issue)

How Has This Been Tested? This fix has been tested on AMD box using dace backend with and without orchestration option using CPUs.

Checklist:

xyuan commented 1 month ago

here is the test output using dace backend and layout 2x2 with orchestration on CPU using 24 mpi ranks

2024-07-29 20:55:58|INFO|rank 19|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 17|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 18|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 23|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 21|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 22|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 23|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 21|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 22|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 3|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 1|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 2|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 1|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 3|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 2|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 4|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 4|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 16|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 16|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 20|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 0|ndsl.logging:diagnostics for step 2000-01-01 00:15:00 finished 2024-07-29 20:55:58|INFO|rank 20|ndsl.logging:cleaning up driver 2024-07-29 20:55:58|INFO|rank 0|ndsl.logging:cleaning up driver