Open fmalatino opened 3 weeks ago
Given that metric terms, and the grid generation methods as a whole are a part of NDSL, does it make sense to move the unit test tests/main/grid/test_eta.py
in Pace to NDSL?
Given that metric terms, and the grid generation methods as a whole are a part of NDSL, does it make sense to move the unit test
tests/main/grid/test_eta.py
in Pace to NDSL?
Yes, please pull it down. We decided that the FV grid would come preset with NDSL, let's commit fully to it.
Description A conditional statement has been added to the
__init__
method of theMetricTerms
class to allow for generating surface level metric terms (no hybrid pressure values). Initialization of such aMetricTerms
object will now contain zero-valued hybrid pressures.The unit test
test_eta.py
frompace/tests/main/grid
has now been moved intondsl/tests/grid
along with a python module for generating the test eta level containing files.This PR must be reviewed and merged after PR 92 is merged in pace
How Has This Been Tested? Tested via the tests contained within the
tests
directory of NDSL, and in the tests of the dependent repositoriesPace tests will fail as the changes from PR 92 in Pace are necessary for passing.
Checklist: