NOAA-GFDL / PyFV3

Python version of FV3 dynamical core
GNU General Public License v3.0
3 stars 6 forks source link

Update dockerfile and makefile #6

Closed oelbert closed 4 months ago

oelbert commented 5 months ago

Description This PR adds a dockerfile to ease development and testing of pyFV3, similar to fv3core, and updates the makefile to streamline everything and shed some of the AI2 artifacts. This also adds an example jupyter notebook that uses the NDSL infrastructure to run a pyFV3 stencil on the cubed-sphere and run halo updates, and fixes the doubly-periodic test.

How Has This Been Tested? To test this I ran all of the savepoint tests and the doubly periodic test using the makefile, and used test_functionality.ipynb to ensure that the pyFV3 and NDSL code is available and functioning correctly inside the container.

Checklist:

oelbert commented 5 months ago

Good question about the notebook. I think nbconvert should cover it if the CI platform can support 6 ranks and has ipyparallel?

FlorianDeconinck commented 5 months ago

Good question about the notebook. I think nbconvert should cover it if the CI platform can support 6 ranks and has ipyparallel?

I very much expect it, yes.

FlorianDeconinck commented 5 months ago

Please merge in develop instead of main