Closed oelbert closed 4 months ago
Good question about the notebook. I think nbconvert should cover it if the CI platform can support 6 ranks and has ipyparallel?
Good question about the notebook. I think nbconvert should cover it if the CI platform can support 6 ranks and has ipyparallel?
I very much expect it, yes.
Please merge in develop
instead of main
Description This PR adds a dockerfile to ease development and testing of pyFV3, similar to fv3core, and updates the makefile to streamline everything and shed some of the AI2 artifacts. This also adds an example jupyter notebook that uses the NDSL infrastructure to run a pyFV3 stencil on the cubed-sphere and run halo updates, and fixes the doubly-periodic test.
Dockerfile
: Added file, contains recipe for an image that can run tests, run pyFV3 code, and visualize model outputsMakefile
: Replaced fvcore makefile with one that doesn't reference vcm/ai2cm, but successfully gets test data, builds a docker image, runs tests, and launches an ipynb server from the imageexamples/notebook/test_functionality.ipynb
: Jupyter notebook that uses most of the NDSL model functionality to run a stencil in paralleltests/mpi/test_doubly_periodic.py
: Fixed metric terms setup so it reads an eta file that should live in test dataHow Has This Been Tested? To test this I ran all of the savepoint tests and the doubly periodic test using the makefile, and used
test_functionality.ipynb
to ensure that the pyFV3 and NDSL code is available and functioning correctly inside the container.Checklist: