search

NOAA-GFDL / SHiELD_build

Other
7 stars 17 forks source link

Build system updates #12

Closed bensonr closed 2 years ago

bensonr commented 2 years ago

Fixes issues #2, #6, and #11 and includes updates from PR #7 and #10

There will be corresponding PR's in SHiELD_physics and FV3

bensonr commented 2 years ago

FMS v2022.02 does require the -DGFS_CONSTANTS macro. Yes, this release is designed to get us up to date with FMS v2022.02 and use the SHiELD versions of atmos_drivers and FMSCoupler. You are correct the inclusion of FMSCoupler and atmos_drivers is not backwards compatible with older FMS versions

lharris4 commented 2 years ago

Great. Thanks for letting me know, this is very helpful.

Lucas

On Thu, May 12, 2022 at 12:08 PM Rusty Benson @.***> wrote:

FMS v2022.02 does require the -DGFS_CONSTANTS macro. Yes, this release is designed to get us up to date with FMS v2022.02 and use the SHiELD versions of atmos_drivers and FMSCoupler. You are correct the inclusion of FMSCoupler and atmos_drivers is not backwards compatible with older FMS versions

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/SHiELD_build/pull/12#issuecomment-1125176862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVBL4B4AKHUBVDKAKSLVJUUHLANCNFSM5VYSFCXA . You are receiving this because you commented.Message ID: @.***>

laurenchilutti commented 2 years ago

I tested this and the other 2 PRs and it looks good. We can merge all 3 PRs whenever you'd like.