NOAA-GFDL / SHiELD_build

Other
7 stars 17 forks source link

Make modifications needed to build a Python-wrapped version of SHiELD #28

Closed spencerkclark closed 11 months ago

spencerkclark commented 11 months ago

Description

This PR makes changes required for building a Python wrapped version of SHiELD. It does two main things:

Fixes #27

How Has This Been Tested?

These changes have been tested in ai2cm/SHiELD-wrapper#1. The continuous integration setup there builds the fortran model and its dependencies using the COMPILE script, builds the Python wrapper, and runs several tests. An important test checks that the Python-wrapped model produces bit-for-bit identical results to the fortran executable for an identically configured run.

Checklist:

Please check all whether they apply or not

spencerkclark commented 11 months ago

Thanks for the review @laurenchilutti -- good catch. I added default values for the pic argument in all of the relevant scripts. Let me know if you'd like me to make any more changes.

spencerkclark commented 11 months ago

Thanks @laurenchilutti and @bensonr!