Closed spencerkclark closed 11 months ago
Thanks for the review @laurenchilutti -- good catch. I added default values for the pic
argument in all of the relevant scripts. Let me know if you'd like me to make any more changes.
Thanks @laurenchilutti and @bensonr!
Description
This PR makes changes required for building a Python wrapped version of SHiELD. It does two main things:
coupler_main.F90
driver into static libraries, which downstream applications can link to (for now I did this only for theshield
configuration option, but I could make a similar change for thesolo
configuration as well).nopic
/pic
option to theCOMPILE
,BUILDlibfms
, andBUILDnceplibs
scripts, and adding anPIC
option to the Makefile templates for thegnu
,intel
, andnvhpc
compilers.Fixes #27
How Has This Been Tested?
These changes have been tested in ai2cm/SHiELD-wrapper#1. The continuous integration setup there builds the fortran model and its dependencies using the
COMPILE
script, builds the Python wrapper, and runs several tests. An important test checks that the Python-wrapped model produces bit-for-bit identical results to the fortran executable for an identically configured run.Checklist:
Please check all whether they apply or not