search

NOAA-GFDL / SHiELD_build

Other
7 stars 17 forks source link

remove extra checked out and compiled files for ocean/ice components #44

Closed JosephMouallem closed 3 weeks ago

JosephMouallem commented 1 month ago

This PR aims to clean up the ocean/ice code used for SHiEMOM by removing extra checked-out and compiled codes. The test case with the new exec runs Ok.

breichl commented 1 month ago

I chatted w/ Bob to get more insight into why the XMLs typically checkout MOM6 and SIS2 as submodules of MOM6-examples instead of directly checking out MOM6 and SIS2. He said it is about ensuring MOM6 and SIS2 remain compatible (SIS2 relies on code in MOM6, so that certain versions of SIS2 will not work with certain versions of MOM6). By using the submodules from MOM6-examples we only need to track one repository and are ensured the code bases are compatible and upgraded together. So, a drawback of the approach proposed here is that we have some additional steps when we upgrade MOM6 and SIS2 so they are done consistently and not independently (this could be done by simply checking out the same versions in MOM6-examples dev/gfdl).

Regardless, I am okay with this change if it is preferred to avoid the additional overhead of MOM6-examples. We just need to remain careful that updates to the MOM6 and SIS2 code bases are handled together.