search

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2
Other
16 stars 43 forks source link

+Added 4 new diagnostics to comply with CMOR #146

Closed Hallberg-NOAA closed 3 years ago

Hallberg-NOAA commented 3 years ago

Added 4 new diagnostics to comply with CMOR requirements for units and how the diagnostics are calculated. Because the suggested CMOR names were already in use, they have been added with _CMOR appended to their names. The four new diagnostics in question are "siconc_CMOR", "sivol_CMOR", "sisnconc_CMOR" and "sitemptop_CMOR", and of course there are new entries in the SIS.available_diags files. This PR closes SIS2 issues #91, #92, and #93. In addition by making the axes in the registration call for "RDG_FRAC" consistent with the dimensionality of the diagnostic that is written out, this PR might also have addressed SIS2 issue #138. The new diagnostics have been visually confirmed to be credible, and all solutions are bitwise identical.

marshallward commented 3 years ago

Post-commit verification: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12565 :heavy_check_mark: