MOM EOS pointer API update

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2

Other

16 stars 43 forks source link

Closed marshallward closed 2 years ago

marshallward commented 2 years ago

This patch updates the equation of state (EOS) calls in SIS2 to use the updated MOM EOS API:

EOS_end is removed, since there is no longer anything to deallocate
THE EOS type is allocated prior to calling EOS_init, rather than relying on the internal allocation. This is because EOS_init no longer expects a pointer, and no longer does this allocation.

This patch may still work with the older version of MOM6, although the EOS pointer will be double-allocated.

marshallward commented 2 years ago

Hallberg-NOAA commented 2 years ago

This PR has been tested with the existing version of MOM6, and it works, reproducing all existing answers and output.

Careful inspection of the MOM6 code shows that there will be no double-allocation of EOS pointers.