marshallward
commented
2 years ago Gaea regrssion: https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/16526 :heavy_check_mark: :yellow_circle:
Changing Tskin units from Kelvin to deg C requires a parameter update.
Applied dimensional rescaling to all SIS2 temperature variables. All answers and output are bitwise identical. The specific changes with this commit include:
Changes to the unit descriptions in the comments for about 188 variables
Renamed a handful of internal variables or arguments from T to Temp to help ensure that these variables were being scaled properly
Added scale arguments to 14 get_param calls for temperature parameters
Added scale arguments to 5 MOM_read_data calls for temperatures
Added or modified scale arguments for 10 checksum calls
Added a new element T_0degC to the ice_state_type
Added a rescaled surface temperature array to pass to update_icebergs
Removed 12 unused variables and an unnecessary call to calculate_T_Freeze()
Modified two data_override calls to use the interface that allows internal rescaling
Added comments describing some previously undescribed variables
Addition of the new elements degC_to_C and C_to_degC to the ice_thermo_type
Added unit_scale_type arguments to bright_ice_temp(), get_sea_surface(), alloc_IST_arrays() and ice_rad_register_restarts()