search

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2
Other
16 stars 43 forks source link

Icepack area underflow patch #184

Closed MJHarrison-GFDL closed 2 years ago

MJHarrison-GFDL commented 2 years ago

New parameter RIDGE_AREA_UNDERFLOW is introduced in order to avoid the occurrence of undetectably small fractional area and negative ice volume following ridging adjustments from Icepack. The default is 0.0, which does not introduce changes in existing runs. A reasonable value would be 10^-26 which would correspond to an Angstrom-scale ice patch within a km-scale grid cell. This addresses #178 and #183

marshallward commented 2 years ago

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/16960 :heavy_check_mark:

I will squash-merge this PR.

kshedstrom commented 2 years ago

I'm afraid you have to check for negative ice volume as well. I get:

WARNING from PE    63: Negative ice thickness at:    233   235     7 -6.2085E-61

FATAL from PE    63: Negative thickness input to ice_continuity().