search

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2
Other
16 stars 43 forks source link

Use open_ASCII_file for sum output #193

Closed marshallward closed 1 year ago

marshallward commented 1 year ago

The generic open_file call was replaced with the targeted open_ASCII_file function, since the generic open_file no longer works with the updated FMS2 open_file interface in MOM6.

kshedstrom commented 1 year ago

How about this one?

//import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/SIS2/src/SIS_dyn_cgrid.F90:2271:78:

                      form=ASCII_FILE, threading=MULTIPLE, fileset=SINGLE_FILE)
                                                                              1
Error: Type mismatch in argument ‘io_handle’ at (1); passed INTEGER(4) to TYPE(file_type)

I think it's pointing to SINGLE_FILE

marshallward commented 1 year ago

I tested against FMS1 :facepalm: thanks @kshedstrom.

kshedstrom commented 1 year ago

I now approve this PR. So the open_file in SIS_restart.F90 must not be a problem.

marshallward commented 1 year ago

I now approve this PR. So the open_file in SIS_restart.F90 must not be a problem.

That's right, the restart file is still on the infra (FMS) layer, so the existing open_file interface ought to work.

raphaeldussin commented 1 year ago

I ran into this issue trying to compile with FMS2, +1 on this PR!

marshallward commented 1 year ago

Sorry, we will get this in very soon once the CI has been reincarnated.

Hallberg-NOAA commented 1 year ago

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/SIS2/-/pipelines/19301.