search

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2
Other
16 stars 43 forks source link

Fix for MOM6 issue #364 #195

Closed kshedstrom closed 1 year ago

kshedstrom commented 1 year ago

Corrects call to FMS2 interface requiring the domain argument.

marshallward commented 1 year ago

Now that our CI is finally working, I was able to test this. Although it works with FMS2 I/O, it is failing with the FMS1. I am fairly certain the problem is that the legacy open_file() wrapper function is not as robust as I had thought, and that is causing some issues with IO layouts.

I think that this will work if the instances of file_type and field are flipped over to MOM_infra_file and MOM_field, since the open() function does some extra work to spoof the IO_domain, but making those changes will be a bit more work.

I wither either submit those changes to this PR or put them in as a new one. Either way, I'll keep you updated @kshedstrom.

marshallward commented 1 year ago

I've opened #196 which should address this issue.

marshallward commented 1 year ago

Closing this issue since #196 handles the issue.