Separating sea ice melt/formation from liquid precipitation field

NOAA-GFDL / SIS2

NOAA-GFDL's Sea Ice Simulator version 2

Other

16 stars 43 forks source link

Separating sea ice melt/formation from liquid precipitation field #214

Open hdrake opened 3 months ago

hdrake commented 3 months ago

For unjustified legacy reasons, these have been bundled together in the past. They are not only bundled together in SIS2 variables, but also in the ice-ocean fluxes passed to the coupler and hence to MOM6.

This commit attempts to address this Issue: https://github.com/NOAA-GFDL/SIS2/issues/213

However, I currently am getting a SEGFAULT error stating that iobt%seaice_melt has not been allocated memory when I try to do a checksum on it.

(Edit: See compaion PRs https://github.com/NOAA-GFDL/MOM6/pull/710 and https://github.com/NOAA-GFDL/FMScoupler/pull/145)

hdrake commented 3 months ago

This is the line that is currently giving me problems when running:

https://github.com/NOAA-GFDL/MOM6/blob/b3e65c63533bf17ae3dd70243f8827fa277ff386/config_src/drivers/FMS_cap/MOM_surface_forcing_gfdl.F90#L1799

If I remove it, the model runs (I am using the Baltic_OM4_05 configuration for testing, with a diag_table that includes fsitherm from the ocean_model) but then the fsitherm diagnostic stays full of zero and is not being currently overwritten by the coupling with SIS2.

hdrake commented 3 months ago

@theresa-morrison pointed out that that I forgot to allocate the new seaice_melt field in the coupler!

After doing so in this PR, my Baltic sea test now works!