ceblanton
commented
2 months ago To try to test this, I pip installed this branch on top of the fre-cli conda installed environment.
But then the "fre pp --help" is complaining about a mismatch between "convert" and "_convert" seemingly. wrapper.py is looking for _convert but configureScriptXML.py has convert. This looks like a tiny change so I'll just change one of them.
(fre-cli) c2b:~/git/fre-cli%>/home/c2b/.local/bin/fre pp --help
/home/c2b/.local/lib/python3.9/site-packages/fre/pp
Traceback (most recent call last):
File "/home/c2b/.local/bin/fre", line 5, in <module>
from fre.fre import fre
File "/home/c2b/.local/lib/python3.9/site-packages/fre/__init__.py", line 5, in <module>
from .pp import *
File "/home/c2b/.local/lib/python3.9/site-packages/fre/pp/__init__.py", line 8, in <module>
from .frepp import ppCli
File "/home/c2b/.local/lib/python3.9/site-packages/fre/pp/frepp.py", line 9, in <module>
from .wrapper import runFre2pp
File "/home/c2b/.local/lib/python3.9/site-packages/fre/pp/wrapper.py", line 32, in <module>
from configureScriptXML import _convert
ImportError: cannot import name '_convert' from 'configureScriptXML' (/home/c2b/.local/lib/python3.9/site-packages/fre/pp/configureScriptXML.py)
ilaflott
Mark II: removed the updates from another branch that I'd mixed into the current branch, fixed a few typos.
The pp wrapper is not ready for anything except testing (it's lacking the logic that we need for production work), but there are several smaller changes to the pp functions that I'd like to incorporate. These center around a wrapper/main function separation for the pp functions that allows you to call them without the decorators that click uses, which means you can invoke those functions from within python rather than on the command line.