search

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

draft: Use git tag for python/conda package version #111

Open ceblanton opened 2 months ago

ceblanton commented 2 months ago

Followed instructions on

https://github.com/jbweston/miniver

may resolve https://github.com/NOAA-GFDL/fre-cli/issues/109

ceblanton commented 2 months ago

I'm disappointed this didn't work. It attempted to retrieve the git tag but came up with unknown:

setuptools.extern.packaging.version.InvalidVersion: Invalid version: 'unknown+g6e734a4'

This miniver package is a lightweight version of versioneer. I'll try versioneer next. I wonder if it's retrieving the tag of the build environment instead of the fre-cli source code.

ilaflott commented 1 month ago

What do we want to accomplish here?

Iterate version number every merge to main?

ceblanton commented 1 month ago

I think we want two deploying pipelines. One for versioned releases, that is triggered by creation of a new git tag. And the second for the testing release, that is triggered by pushes to main.

The part that I'd like from this PR is connecting the conda package version to the git tag version.

It doesn't work, for some reason. I'll change to draft and close it soon. I think replacing setuptools with setuptools-scm might be the most palatable solution to connect the conda package version to the git tag version.

ilaflott commented 1 month ago

are these PRs supposed to be drafts? are they still being worked on? the title having "draft" does not make this PR a draft.