search

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

Remove unneeded chdir and print #116

Closed ceblanton closed 1 month ago

ceblanton commented 2 months ago

The chdir causes the relative path config files to fail. It doesn't appear necessary.

ceblanton commented 2 months ago

@cwhitlock-NOAA are you OK with this? I wasn't sure if we needed to chdir to the import directory for some reason. I don't think we do, and it's probably better to not chdir if we don't need to.

cwhitlock-NOAA commented 2 months ago

I'm fine with it. I had that in because I was trying to fix another issue and then failed to remove it once I resolved the other issue.

On Thu, Jul 11, 2024 at 2:17 PM Chris Blanton @.***> wrote:

@cwhitlock-NOAA https://github.com/cwhitlock-NOAA are you OK with this? I wasn't sure if we needed to chdir to the import directory for some reason. I don't think we do, and it's probably better to not chdir if we don't need to.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/fre-cli/pull/116#issuecomment-2223590109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC362WXYVCUHOT2UX2ZX5GTZL3D2LAVCNFSM6AAAAABKTPPBJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTGU4TAMJQHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Carolyn Whitlock

ceblanton commented 2 months ago

Excellent. Could you click Approve when you get a chance? We enabled these strict rules that require at least one review from the non-author.