search

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

Add catalog validate #117

Closed ceblanton closed 1 month ago

ceblanton commented 2 months ago

This update adds click bindings for "fre catalog validate" to resolve to the test_catalog.py package that will be installed as part of the CatalogBuilder in the "scripts" subdirectory.

ceblanton commented 2 months ago

Needs https://github.com/aradhakrishnanGFDL/CatalogBuilder/pull/139

ceblanton commented 2 months ago

The build is failing due to not finding the "test_catalog.py" but I'm not actually sure what is failing. I think it will pass when the corresponding PR in CatalogBuilder is accepted.

cwhitlock-NOAA commented 2 months ago

That would make sense. Is it possible to merge two test branches together, or does that complicate the merge history?

On Tue, Jul 9, 2024 at 5:23 PM Chris Blanton @.***> wrote:

The build is failing due to not finding the "test_catalog.py" but I'm not actually sure what is failing. I think it will pass when the corresponding PR in CatalogBuilder is accepted.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/fre-cli/pull/117#issuecomment-2218754974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC362WWJUKG57JUBL4FJHOLZLRIGNAVCNFSM6AAAAABKTTOGCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYG42TIOJXGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Carolyn Whitlock

ceblanton commented 2 months ago

That would make sense. Is it possible to merge two test branches together, or does that complicate the merge history? … On Tue, Jul 9, 2024 at 5:23 PM Chris Blanton @.> wrote: The build is failing due to not finding the "test_catalog.py" but I'm not actually sure what is failing. I think it will pass when the corresponding PR in CatalogBuilder is accepted. — Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC362WWJUKG57JUBL4FJHOLZLRIGNAVCNFSM6AAAAABKTTOGCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYG42TIOJXGQ . You are receiving this because you are subscribed to this thread.Message ID: @.> -- Carolyn Whitlock

Thanks Carolyn. The problem is similar to the "fre pp checkout --branch=main" option you added. The problem is they are seperate repositories, and fre-cli only has access (via the conda prerequisite) to the deployed main branch of catalog builder.

I think once catalog builder is updated this PR will pass without any changes. We'll see.

ilaflott commented 1 month ago

Where is scripts and why isn't it in the branch?

This code seems awfully dependent on what is in there. Is that a pip install'ed module/package?

ilaflott commented 1 month ago

Where is scripts and why isn't it in the branch?

This code seems awfully dependent on what is in there. Is that a pip install'ed module/package?

ah, from here: https://github.com/aradhakrishnanGFDL/CatalogBuilder

ceblanton commented 1 month ago

Hmmm the tests are passing the there's a merge conflict now. gen_intake_gfdl.py is not needed at all I believe

aradhakrishnanGFDL commented 1 month ago

Post discussion at the data catalog meeting- A new issue is created to address the test_catalog name change. A new PR will address the change of names in fre-cli and catalog builder.. so this PR can be closed with the existing functionality and file names.

Ciheim commented 1 month ago

Echoing Aparna's comment here that we will make sure to change the script name and avoid the 'test_' convention in the future.