NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

Include quotes in the rose-suite.conf values #139

Closed ceblanton closed 1 month ago

ceblanton commented 1 month ago

Describe your changes

Recent updates to fre pp configure-yaml seem to require quotes to pass Cylc validation.

Issue ticket number and link (if applicable)

99

Checklist before requesting a review

ilaflott commented 1 month ago

this is the perfect candidate for a test. @cwhitlock-NOAA myself, and now presumably you and @singhd789 have all tripped over this.

ilaflott commented 1 month ago

apologies for accidental closing!

ceblanton commented 1 month ago

Not ready, yet. Discovered some more quoting issues (booleans do not want to be quoted- arggg!)

ceblanton commented 1 month ago

Ha! Yes, it was the booleans, you were exactly right

ilaflott commented 1 month ago

from the pytest suite-

fre/pp/tests/test_rose_quoting.py ..                                     [ 58%]

totally fab. totally gorg.