NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

upgrade the version of sphinx-rtd-theme to fix "style is undefined" #148

Closed ceblanton closed 1 month ago

ceblanton commented 1 month ago

Describe your changes

Our sphinx CI building suddenly stopped working with this error:

Reason: UndefinedError("'style' is undefined")

Others have found that the cause is a mismatch between sphinx and sphinx-rtd-theme, and is fixed by updating the latter.

https://github.com/readthedocs/sphinx_rtd_theme/issues/1571

Issue ticket number and link (if applicable)

Checklist before requesting a review

ceblanton commented 1 month ago

124

ilaflott commented 1 month ago

I think we should be staying consistent between pip and conda in a way that seems intentional and non-arbitrary. I prefer the current version-

          pip install sphinx renku-sphinx-theme sphinx-rtd-theme
          pip install --upgrade sphinx-rtd-theme

i wonder if the renku one can be omitted, and the --upgrade flag can be added elsewhere for even more brevity? I'll try it out.

          pip install --upgrade sphinx sphinx-rtd-theme
ilaflott commented 1 month ago

no one-liner :-( but consistent