search

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 11 forks source link

fre catalog build requires API update #149

Closed ceblanton closed 2 months ago

ceblanton commented 3 months ago

Describe the bug Recent updates in CatalogBuilder,

https://github.com/NOAA-GFDL/CatalogBuilder/pull/29/files

require small updates to the fre-cli code.

To Reproduce run fre catalog build on any pp directory

Expected behavior

Additional context Add any other context about the problem here.

ceblanton commented 3 months ago

@aradhakrishnanGFDL fyi

ilaflott commented 3 months ago

I'm confused, the click API looks identical. The linked PR was closed, not merged?

ilaflott commented 3 months ago

mm...

(fre_cli) an010: fre-cli $] fre catalog builder /archive/Ian.Laflotte/fre/FMS2023.04_om5_20240410/ESM4.2JpiC_om5b04r1/gfdl.ncrc5-intel23-prod-openmp/pp
Traceback (most recent call last):
  File "/home/Ian.Laflotte/conda/envs/fre_cli/bin/fre", line 8, in <module>
    sys.exit(fre())
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/Ian.Laflotte/conda/envs/fre_cli/lib/python3.9/site-packages/fre/catalog/frecatalog.py", line 29, in builder
    context.forward(gen_intake_gfdl.main)
AttributeError: module 'catalogbuilder.scripts.gen_intake_gfdl' has no attribute 'main'
(fre_cli) an010: fre-cli $]
ilaflott commented 3 months ago

another thought- this should be caught by a test.

aradhakrishnanGFDL commented 3 months ago

@Ciheim is on it, plan is to swap main with create_catalog and troubleshoot as needed. +1 for tests.

Examples and tests are added to catalogbuilder and docs for reference, in some shape or form.

And, this might be the correct PR in catalogbuilder to reference.