Closed ilaflott closed 2 months ago
pylint score in current main
branch is 3.34. These edits bring the code to about a 4.70. The aim is to address enough of the complaints that the score will easily fall if low quality code is committed in the future.
quick summary of changes:
# pylint: disable=unused-argument
, to ignore unused arguments in certain places for now netCDF4.Dataset
fre <tool>
calls, fre catalog builder
calls to make sure we have something that might catch an API change on that front. this PR now contains autogenerated documentation from python doc-strings! https://github.com/NOAA-GFDL/fre-cli/actions/runs/10372226899/job/28714459606?pr=151
ready to go
Describe your changes
split up cli tests, add a new one based on the
catalogbuilder
interface, so we'll know if it changes again via a failed test.Issue ticket number and link (if applicable)
149
Checklist before requesting a review
- [x] I wrote new instructions/documentation, if applicable