search

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.
GNU Lesser General Public License v3.0
3 stars 7 forks source link

FRE cmor run #52

Closed ceblanton closed 5 months ago

ceblanton commented 6 months ago

fre-cli interface for Climate Model Output Rewriter (CMOR)

Also includes some cmor-mixer updates from a user.

ceblanton commented 5 months ago

This is passing the tests now, whoa!

bcc2761 commented 5 months ago

@ceblanton Yes, the issue was in that one line I commented out, the git_url within the source. My bad for not catching it earlier when I'm the one who added it and not trying to understand what it is more before adding it in. I'm not sure how Carolyn's changes to fre pp checkout were able to successfully be updated recently, because what I discovered is that this specifier was performing the conda build using the repo's url, which obviously points to the main branch and doesn't have the local changes/updates within the PR. I realized this was a meta.yaml/git issue after trying to conda build with the refactored branch yet it was still having the 'fre' in front of the modules. So this should be fixed for now, but I still want to address the 'clobber warning' and 'package not included' warnings in the workflow run

cwhitlock-NOAA commented 5 months ago

Hey Bennet - the answer here seems to be that I wasn't using meta.yaml - I had no idea that file existed!

Instead, the path to the repo is hard-coded within checkoutScript.py around line 61:

clonecmd = f"git clone -b {branch} --single-branch --depth=1 --recursive https://gitlab.gfdl.noaa.gov/fre2/workflows/postprocessing.git {name}"

I can update it to use meta.yaml instead, if that's what we're using for our site-specific vars.

On Mon, Apr 1, 2024 at 4:34 PM Bennett Chang @.***> wrote:

@ceblanton https://github.com/ceblanton Yes, the issue was in that one line I commented out, the git_url within the source. My bad for not catching it earlier when I'm the one who added it and not trying to understand what it is more before adding it in. I'm not sure how Carolyn's changes to fre pp checkout were able to successfully be updated recently, because what I discovered is that this specifier was performing the conda build using the repo's url, which obviously points to the main branch and doesn't have the local changes/updates within the PR. I realized this was a meta.yaml/git issue after trying to conda build with the refactored branch yet it was still having the 'fre' in front of the modules. So this should be fixed for now, but I still want to address the 'clobber warning' and 'package not included' warnings in the workflow run

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/fre-cli/pull/52#issuecomment-2030509020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC362WVOS2XFYMIIYRTDY2DY3HADRAVCNFSM6AAAAABE4SCUP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGUYDSMBSGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Carolyn Whitlock