PP configure-yaml updates

NOAA-GFDL / fre-cli

Python-based command line interface for FRE (FMS Runtime Environment) to compile and run FMS-based models and post-process their output.

GNU Lesser General Public License v3.0

3 stars 7 forks source link

PP configure-yaml updates #94

Closed ceblanton closed 3 months ago

ceblanton commented 3 months ago

Minor cleanup:

use metomi.rose for writing rose config files
retrieve pathnames from command line arguments instead of pp.yaml

Also simplify some of the pp.yaml component definitions, by removing timeseries and timeaverage tags that are not absolutely needed in canopy.

ceblanton commented 3 months ago

@singhd789 and @Ciheim is this update OK to go in? I'm afraid it will affect your ppp configurations but it's worth it. (I was shamelessly going to click review/merge it in but the person who submitted the PR is not allowed to review by our repo rules..)

singhd789 commented 3 months ago

@singhd789 and @Ciheim is this update OK to go in? I'm afraid it will affect your ppp configurations but it's worth it. (I was shamelessly going to click review/merge it in but the person who submitted the PR is not allowed to review by our repo rules..)

Hey @ceblanton Chris, sorry for the delay. I just added some comments

edit: I just realized my comments were pending and you couldn't see them. You should be able to now

ceblanton commented 3 months ago

Thanks so much for your review @singhd789 . I updated the pp schema and added back the container-specific pp.yaml items. It's ready for another review from you. No rush.. next week is fine. thanks!