We check if the analysis script is readable, and if not we then check if it the script is in FRE_ANALYSIS_HOME or if it's in app/analysis/file. However, if the user enters the full path to the analysis script (i.e /home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.csh ) instead of just the scripts name, the ascript variable in this section will contain the full path and the first else statement will set ascript equal to /app/analysis/file//home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.csh instead of app/analysis/file/mdtf_gfld.csh.
We can probably get around this by setting ascript = analysis_file_suffix+ascript.split('/')[-1], or something along those lines.
As a minor side note, /home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.csh no longer exists, so we should probably replace this with just mdtf_gfdl.csh in app/analysis/rose-app.conf.
In the following lines of
/meta/lib/python/macros/analysis_validator.pyhttps://github.com/NOAA-GFDL/fre-workflows/blob/c18dedd918a09fef11a24ffcab692ab8d86a3e7b/meta/lib/python/macros/analysis_validator.py#L91-L112
We check if the analysis script is readable, and if not we then check if it the script is in
FRE_ANALYSIS_HOMEor if it's inapp/analysis/file. However, if the user enters the full path to the analysis script (i.e/home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.csh) instead of just the scripts name, theascriptvariable in this section will contain the full path and the firstelsestatement will setascriptequal to/app/analysis/file//home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.cshinstead ofapp/analysis/file/mdtf_gfld.csh.We can probably get around this by setting
ascript = analysis_file_suffix+ascript.split('/')[-1], or something along those lines.As a minor side note,
/home/oar.gfdl.mdtf/mdtf/MDTF-diagnostics/sites/NOAA_GFDL/mdtf_gfdl.cshno longer exists, so we should probably replace this with justmdtf_gfdl.cshinapp/analysis/rose-app.conf.