search

NOAA-GFDL / fre-workflows

Code to generate, describe, validate, and configure scientific workflows within the FRE software framework
2 stars 4 forks source link

Potential bad paths in remap-pp-components #9

Closed menzel-gfdl closed 3 months ago

menzel-gfdl commented 3 months ago

The if condition is not correct here:

https://github.com/NOAA-GFDL/fre-workflows/blob/138600c05ddfd7dee80ef2c27dfded551cd02ca2/app/remap-pp-components/bin/remap-pp-components#L452

It should read if ens_mem is None. Also, can we change those check=False options to check=True? That should make the script fail instead of saying it passes.

ilaflott commented 3 months ago

updated original issue text w/ permalink. without it- what the problem was is not clear.