search

NOAA-GFDL / mkmf

Other
10 stars 51 forks source link

Revert backslash escapes to git-version-string output #34

Closed ceblanton closed 4 years ago

ceblanton commented 4 years ago

Reverts the recent update that escaped the quotes in the call to git-version-string in mkmf.

Also updates the mkmf version number.

Resolves #33

underwoo commented 4 years ago

Simply reverting the backslash (\) is not sufficient. The fix was put in for a reason. We will need to look at what is causing the current issue, and the previous issue that required the backslash. Please hold off on correcting this for the moment.

ceblanton commented 4 years ago

Gotcha, will close this. Quoting issues are tricky for sure.

underwoo commented 4 years ago

@ceblanton, @bensonr responded to #33 with information on what required the backslash. It was a quoting issue when using the Intel MPI compiler wrappers mpiifort and mpiicc. Work with Luis on a possible solution.