Updates for boundary layer residence time tracer and flexible gas params

NOAA-GFDL / ocean_BGC

4 stars 27 forks source link

Updates for boundary layer residence time tracer and flexible gas params #3

Closed jkrasting closed 4 years ago

jkrasting commented 4 years ago

This PR includes two updates by @mclaret moved over to from NOAA-GFDL's internal Gitlab. Since the work was intertwined with 13C tracer development (not included here), the code needed to be manually moved over.

The two updates here include:

Introduction of a boundary layer residence time tracer
Flexible air-sea exchange coefficients as runtime parameters

jkrasting commented 4 years ago

@nikizadehgfdl, @StephenGriffies here are updates as candidates for the hires development.

nikizadehgfdl commented 4 years ago

This PR preserves answers for OM4p5 COBALT experiment.

jkrasting commented 4 years ago

Does it also preserve answers for OM4p5 BLING in your regression tests? Do the standard regression tests exercise the CFC and SF6 answers?

nikizadehgfdl commented 4 years ago

The ocean-ice test I ran exercises cfc's, sf6 and abio as well as COBALT. They all reproduced (does that make sense?) There is a new tracer called ab_htotal14c in the restarts. For BLING I'll run the OMIP4 and CM4 experiments.

jkrasting commented 4 years ago

@nikizadehgfdl - that's great. Thanks. Glad the tests are covering all of these cases.

nikizadehgfdl commented 4 years ago

Bling answers are also preserved, except curiously for one tracer called "dissi14cabio". @jkrasting , does that make sense? Here's the diff on gaea ncview /lustre/f2/scratch/Niki.Zadeh/tmp/ardiff.gaea13.42249.wiXRlc7MGE/MOM.res_1.nc made by cd /lustre/f2/scratch/Niki.Zadeh/tmp/ardiff.gaea13.42249.wiXRlc7MGE ncdiff first/MOM.res_1.nc second/MOM.res_1.nc MOM.res_1.nc

jkrasting commented 4 years ago

That's to be expected @nikizadehgfdl. This includes bug fixes for 14C. The separate htotal tracer for 14C is also removed.

Sorry - should have mentioned that in the PR.