This pull request partially addresses Issue #28 regarding methods of differing names, but similar functionality. This will be on-going as more methods of this type are discovered.
Code changes:
Functions initialize_delp and _initialize_delp merged into one function: initialize_delp (in fv3core/pace/fv3core/initialization/init_utils.py)
Functions initialize_edge_pressure and _initialize_edge_pressure merged into one function: initialize_edge_pressure (in v3core/pace/fv3core/initialization/init_utils.py)
References to _initialize_delp and _initialize_edge_pressure in fv3core/pace/fv3core/initialization/test_cases/init_tc.py updated to reflect changes
Requirements changes:
N/A
Infrastructure changes:
N/A
Checklist
Before submitting this PR, please make sure:
[x] You have followed the coding standards guidelines established at Code Review Checklist.
[x] Docstrings and type hints are added to new and updated routines, as appropriate
[x] All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
[x] For each public change and fix in pace-util, HISTORY has been updated
[x] Unit tests are added or updated for non-stencil code changes
Additionally, if this PR contains code authored by new contributors:
[x] The names of all the new contributors have been added to CONTRIBUTORS.md
Purpose
This pull request partially addresses Issue #28 regarding methods of differing names, but similar functionality. This will be on-going as more methods of this type are discovered.
Code changes:
Requirements changes:
Infrastructure changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updatedAdditionally, if this PR contains code authored by new contributors: