search

NOAA-GFDL / pace

Re-write of FV3GFS weather/climate model in Python
Apache License 2.0
12 stars 11 forks source link

rename 'ks' variable in Pace #34

Open bensonr opened 10 months ago

bensonr commented 10 months ago

The ks variable in Pace and FV3 is supposed to designate the topmost layer in which the bk of the eta pair becomes zero. That layer and above is known as the sponge layer. It makes sense to rename the variable in Pace to be more descriptive as it does not have the same meaning as is and js.

lharris4 commented 10 months ago

This variable may not be necessary for our current purposes; any model component that needs it can easily re-compute it from the ak/bk coefficients. So we could just remove it.

Minor correction: above ks is where the reference coordinate becomes a pure-pressure coordinate and surface pressure has no influence. It is not necessarily the sponge layer, in which additional damping is applied near the upper boundary.

bensonr commented 10 months ago

@lharris4 - thanks for the clarifications! BTW, @oelbert and I chatted about the need for this variable and maybe removing it before deciding to open a discussion and get your input.

lharris4 commented 10 months ago

Glad to help :-)

On Thu, Oct 26, 2023 at 6:32 PM Rusty Benson @.***> wrote:

@lharris4 https://github.com/lharris4 - thanks for the clarifications! BTW, @oelbert https://github.com/oelbert and I chatted about the need for this variable and maybe removing it before deciding to open a discussion and get your input.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/pace/issues/34#issuecomment-1781980462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMUQRVFTRXHDFUCEWAYICKDYBLQHHAVCNFSM6AAAAAA6RWNRM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRHE4DANBWGI . You are receiving this because you were mentioned.Message ID: @.***>