NOAA-GFDL / pace

Re-write of FV3GFS weather/climate model in Python
Apache License 2.0
12 stars 11 forks source link

[orch:dace:X] bad reinterpret cast leads to NaN #4

Open FlorianDeconinck opened 1 year ago

FlorianDeconinck commented 1 year ago

In AcousticsDynamics.__call__ a couple of dt are being computed. Namely:

When using Float=np.float32 (or PACE_FLOAT_PRECISION=32) those still remains 64-bit float, even when type hinted to Float. This is a DaCe bug. To go around it we use two callbacks (dt_acoustic_substep, and dt2 on self) which forces the type has a return.

DaCe to fix - Pace to remove the workaround

FlorianDeconinck commented 8 months ago

Branch https://github.com/GEOS-ESM/pace/tree/feature/f32_dycore_adjustements