FlorianDeconinck commented 8 months ago

Changes

Update: DaCe to 0.15.1 RC and GT4Py to latest main (https://github.com/GEOS-ESM/pace/pull/32)
Minor: orchestration build logging (https://github.com/GEOS-ESM/pace/pull/33)
Minor: dead code clean up (https://github.com/GEOS-ESM/pace/pull/33)

Testing

Validation: dynamical core translate test after https://github.com/GEOS-ESM/pace/pull/32. https://github.com/GEOS-ESM/pace/pull/33 no-op.
Performance : regression has been conducted on GEOS Held-Suarez configuration run at 50km resolution (GCM 1.4.0-2) https://github.com/GEOS-ESM/pace/pull/32. https://github.com/GEOS-ESM/pace/pull/33 no-op.

FlorianDeconinck commented 8 months ago

Can we merge this one as-is ? Then I'll pop a following PR with the comment change.

fmalatino commented 8 months ago

I will merge this now

On Thu, Dec 7, 2023 at 10:23 AM Florian Deconinck @.***> wrote:

Can we merge this one as-is ? Then I'll pop a following PR with the comment change.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GFDL/pace/pull/41#issuecomment-1845543294, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB6BH6UQ6JJLSTEDNH6HTHDYIHNM7AVCNFSM6AAAAABAICTHFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGU2DGMRZGQ . You are receiving this because your review was requested.Message ID: @.***>

-- Frank Malatino Scientific Programmer +1 609.452.5066 (work) +1 609.661.4520 (cell) SAIC/NOAA/GFDL

NOAA-GFDL / pace

[NASA] Update DaCe to v0.15.1 RC #41

Changes

Testing