NOAA-GFDL / pace

Re-write of FV3GFS weather/climate model in Python
Apache License 2.0
12 stars 11 forks source link

Fail to init model on not implemented configurations #46

Open FlorianDeconinck opened 7 months ago

FlorianDeconinck commented 7 months ago

The Pace repository does not carry all the capacity of the FV3 model. Therefore we need to strongly fail when the namelist/configuration required is not going to work or work poorly.

A first implementation is to use raise NotImplementedError in the __init__ function of the modules. DO NOT RAISE AT RUNTIME, keep guard at initialization or fear my wrath.

Current non-exhaustive list:

List to be double checked and completed

FlorianDeconinck commented 7 months ago

PR incoming with some checks

bensonr commented 7 months ago

There are multiple microphysical schemes with the same number of water species, but the makeup of species is different. We need to come up with a better way than using nwat to determine how the water species break down for the liquid vs solid when computing the subgrid scale mixing.