Closed fmalatino closed 4 weeks ago
@fmalatino - before formally reviewing, wanted to make sure the submodule changes for NDSL, pyFV3, and pySHiELD is expected as part of the rollback to Python 3.11.7
@bensonr I figured I would bring the develop
branch up to date with the current versions of the submodules at the same time. I will ammend the initial comment as well.
Looks like you'll have to update any calls to constraints.txt now that it's been split into constraints_38 and constaints_311, though it's probably better to just bump the python version to 3.11 and keep one constraint file. If we want to keep support for python 3.8 it's probably better to use environment markers I think?
Also while we're updating the install environment can we delete lines 20-23 from
pace/Dockerfile
? It seems redundant with lines 24-27
My vote is that we just move to support for 3.11.7. Can do with the lines in the Dockerfile; will be in next push.
Description The
pytest-subtests
package was added to requirements to enable full testing suite. The python version in github workflows was rolled back to 3.11.7 to match environments in submodules. The submodules,NDSL
,pyFV3
, andpySHiELD
are also brought to the latest commits in their respectivedevelop
branchesHow Has This Been Tested? Tested via current test suite
Checklist: