search

NOAA-GFDL / xwmt

Python package for water mass transformation analysis that leverages xarray functionality
https://xwmt.readthedocs.io/
MIT License
7 stars 5 forks source link

Adding some functional tests #26

Closed gmacgilchrist closed 2 years ago

gmacgilchrist commented 2 years ago

This PR adds some additional functional tests to provide answers for default calculations using different lambda values, as well as using different methods within the calculation of .G.

This partially addresses #10.

jkrasting commented 2 years ago

@gmacgilchrist - interesting. These tests failed on the CI, but they did work for me. Curious - what platform did you develop them on?

jkrasting commented 2 years ago

Nevermind @gmacgilchrist -- #29 should fix this issue

jetesdal commented 2 years ago

Thanks @jkrasting for looking into this. Is the test still failing or do we have to re-run the test to check if it is fixed now that #29 has been merged?

jkrasting commented 2 years ago

I rebased @gmacgilchrist's PR just now and submitted #30.