search

NOAA-GSL / ExascaleWorkflowSandbox

Other
2 stars 2 forks source link

Remove Flux and update spack-stack #105

Closed christopherwharrop-noaa closed 2 months ago

christopherwharrop-noaa commented 2 months ago

This PR does several things, all of which are necessary for removal of Flux (closes #103):

  1. Use updated Slurm cluster base containers with officially supported Slurm build
  2. Update containers from Ubuntu20.04 to Ubuntu22.04
  3. Update from spack-stack 1.6.0 to spack-stack 1.7.0
  4. Modify spack-stack container to build OpenMPI with Slurm support
  5. Remove all uses of Flux from the codebase
  6. Migrate all tests from FluxExecutor to MPIExecutor
  7. Fixed tests and test command to allow use of latest pytest version
  8. Update CI workflow to remove Flux containers

The removal of Flux initiated a large chain of events and this PR is the sum total of that work.

christopherwharrop-noaa commented 2 months ago

@NaureenBharwaniNOAA - This is ready for serious review. You might consider actually checking this out and following installation instructions for hera/hercules to see if you can make this work. It should be MUCH easier.

christopherwharrop-noaa commented 2 months ago

@NaureenBharwaniNOAA - Thank you for your very helpful comments so far. I think we are almost done. Please take another look and let me know if you see any outstanding issues that need attention.