Add test to test_mpi_hello to validate run output

NOAA-GSL / ExascaleWorkflowSandbox

Other

2 stars 2 forks source link

Add test to test_mpi_hello to validate run output #50

Closed NaureenBharwaniNOAA closed 9 months ago

NaureenBharwaniNOAA commented 9 months ago

The test_mpi_hello test in tests/test_parsl_flux_mpi_hello.py only checks that the Parsl App completed with a status of 0 (meaning success). It does not actually check whether the output of the task, written to parsl_flux_mpi_hello_run.out is correct. This test needs to be updated to validate the output.

Closes Issue #44

christopherwharrop-noaa commented 9 months ago

When you have a PR that is addressing and issue, it is nice to put "closes #44" somewhere in the PR description. As you type that, a menu will pop up and allow you to select the issue. This happens anytime you type "closes #". Another great benefit is that Github will automatically close the issue(s) you mention when the PR gets merged.