NOAA-GSL / MATS

MATS is a quick & interactive way to view verification statistics
https://gsl.noaa.gov/mats/
6 stars 0 forks source link

Update to Meteor 3.0 #1201

Open ian-noaa opened 4 months ago

ian-noaa commented 4 months ago

Problem

Meteor 3.0 was released on July 16. It contains significant breaking changes to the framework (namely migrating from fibers to async) and migrates off of an end-of-life version of Node. (from v14 to v20) Meteor has published a migration guide.

Solution

To be discussed.

There are two possible paths I see:

  1. migrate from fibers to async on Meteor v2.16, then update to Meteor 3.0
  2. attempt to do the update to Meteor 3.0 in one go

Either way, this should be broken up into small steps to better understand what we need to do.

No Go's

Describe any features or behaviors that have been considered and rejected as out of scope for this project

Tasks

Describe discrete tasks that need to be done to complete this project

ian-noaa commented 4 months ago

@mollybsmith-noaa & @randytpierce, this seemed like a good place to start a discussion around the Meteor 3.0 upgrade. I'm imagining this issue/epic will spawn a number of sub-tasks depending on the upgrade path we want to take.

@mollybsmith-noaa - would this be okay to assign to you?

mollybsmith-noaa commented 4 months ago

Sure, I do want to get to a modern version of Node, but this will take a good chunk of time.

Molly

On Jul 19, 2024, at 12:16 PM, Ian McGinnis @.***> wrote:

@mollybsmith-noaa https://github.com/mollybsmith-noaa & @randytpierce https://github.com/randytpierce, this seemed like a good place to start a discussion around the Meteor 3.0 upgrade. I'm imagining this issue/epic will spawn a number of sub-tasks depending on the upgrade path we want to take.

@mollybsmith-noaa https://github.com/mollybsmith-noaa - would this be okay to assign to you?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GSL/MATS/issues/1201#issuecomment-2239852117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBWGZJBI2MARHJGXV3KYULZNFJZBAVCNFSM6AAAAABLFA44C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZHA2TEMJRG4. You are receiving this because you were mentioned.

mollybsmith-noaa commented 4 months ago

This needs to be done AFTER my consolidate middleware branch is merged back in or we’ll have one heck of a merge conflict.

On Jul 19, 2024, at 12:29 PM, Molly Smith - NOAA Affiliate @.***> wrote:

Sure, I do want to get to a modern version of Node, but this will take a good chunk of time.

Molly

On Jul 19, 2024, at 12:16 PM, Ian McGinnis @.***> wrote:

@mollybsmith-noaa https://github.com/mollybsmith-noaa & @randytpierce https://github.com/randytpierce, this seemed like a good place to start a discussion around the Meteor 3.0 upgrade. I'm imagining this issue/epic will spawn a number of sub-tasks depending on the upgrade path we want to take.

@mollybsmith-noaa https://github.com/mollybsmith-noaa - would this be okay to assign to you?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-GSL/MATS/issues/1201#issuecomment-2239852117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBWGZJBI2MARHJGXV3KYULZNFJZBAVCNFSM6AAAAABLFA44C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZHA2TEMJRG4. You are receiving this because you were mentioned.

ian-noaa commented 4 months ago

I agree on both accounts. 🙂

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 90 days with no activity.