NOAA-GSL / VxIngest

Other
2 stars 0 forks source link

implement the RaobsObsBuilder builder. #185

Open randytpierce opened 1 year ago

randytpierce commented 1 year ago

Implement the RAOBS builder

randytpierce commented 1 year ago

The basic implementation is there but I am putting this in blocked until I determine the best way to handle level interpolation in the API.

bonnystrong commented 1 year ago

Needs Jeff's input.

bonnystrong commented 1 year ago

Need a conversation to include Dave - after Randy and Jeff have discussed.

randytpierce commented 5 months ago

Moving forward on this now. We will decode the prepbufr files with NCEPLIBS-bufr code. This will require a slight refactoring of what I have done so far. There will be a base PrepbufrBuilder class and a subclass RAOBBuilder that will be the actual builder class referenced in the templates.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 90 days with no activity.

randytpierce commented 2 months ago

This is nearly done. The builder is ready for review but two issues remain unresolved. There is a discrepancy between the relative humidity calculations that the legacy code has determined and what this builder determines. Further investigation is required to resolve the discrepancy. There also remains a question about certain station locations. The locations that the builder is deriving from the prepbufr file does not align with known station locations in every case. There are a couiple of stations that are significantly off.

We can review the PR and pursue theses questions independently.