NOAA-GSL / VxIngest

Other
2 stars 0 forks source link

Updating a test job doc can break the test suite for unrelated branches #286

Open ian-noaa opened 8 months ago

ian-noaa commented 8 months ago

Describe the bug

A set of Couchbase test documents (JOB-TEST:V01:METAR:NETCDF:OBS and MD-TEST:V01:METAR:obs:ingest:netcdf) were updated so that PR #285 could be tested. However, due to that the test suite broke for the main branch and for PR #284.

To Reproduce

Steps to reproduce the behavior:

  1. Update a JOB-TEST or related MD-TEST document in Couchbase to work with a feature branch. (E.g. - to add a new handler or change an existing one)
  2. Try to run the test suite on the main branch or on any other feature branch
  3. See test failures

Expected behavior

Changes made in one feature branch ideally shouldn't break the test suite for other branches.

Additional context

Example Problematic Job Doc

DocID: `MD-TEST:V01:METAR:obs:ingest:netcdf` ```diff { "builder_type": "NetcdfMetarObsBuilderV01", "validTimeInterval": 3600, "validTimeDelta": 1800, "docType": "ingest", "subDocType": "netcdf", "id": "MD-TEST:V01:METAR:obs:ingest:netcdf", "requires_time_interpolation": true, "subType": "obs", "subset": "METAR", "template": { "correctedTime": "", "data": { "*stationName": { "Ceiling": "&ceiling_transform|*skyCover,*skyLayerBase", "DewPoint": "&kelvin_to_farenheight|*dewpoint", + "RH": "&handle_rh|*temperature,*dewpoint", "Reported Time": "&umask_value_transform|*timeObs", "Surface Pressure": "&handle_pressure|*altimeter", "Temperature": "&kelvin_to_farenheight|*temperature", "Visibility": "&handle_visibility|*visibility", "WD": "&umask_value_transform|*windDir", + "WindU": "&handle_wind_dir_u|*windDir,*windSpeed", + "WindV": "&handle_wind_dir_v|*windDir,*windSpeed", "WS": "&meterspersecond_to_milesperhour|*windSpeed", "name": "&handle_station|*stationName" } }, "units": { "Ceiling": "ft", "DewPoint": "deg F", "Surface Pressure": "mb", "Temperature": "deg F", "Visibility": "miles", "RH": "percent", "WD": "degrees", "WindU": "m/s", "WindV": "m/s", "WS": "mph" }, "dataSourceId": "MADIS", "docType": "obs", "fcstValidISO": "&derive_valid_time_iso|%Y%m%d_%H%M", "fcstValidEpoch": "&derive_valid_time_epoch|%Y%m%d_%H%M", "id": "DD-TEST:V01:METAR:obs:&derive_valid_time_epoch|%Y%m%d_%H%M", "subset": "METAR", "type": "DD-TEST", "version": "V01" }, "type": "MD-TEST", "version": "V01" } ```

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 90 days with no activity.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 90 days with no activity.