search

NOAA-GSL / VxIngest

Other
2 stars 0 forks source link

better handle vegetation_type when vegetation_type is missing from grib file and also convert vegetation_type to string #315

Closed randytpierce closed 7 months ago

randytpierce commented 7 months ago

I discovered that I had not handled the case where a model didn't have any vegetation_type in the grib file, and i also realized that the handle_vegetation_type was not using the string value of veg_type in the json output. This PR corrects those oversights. I also adds a .prev and .tmp to the unit test for get_files.

ian-noaa commented 7 months ago

Adding Gopa as a reviewer - I believe that was Randy's original intent.

github-actions[bot] commented 7 months ago

Code Coverage

Package Line Rate Branch Rate Health
vxingest 33% 42% ❌
vxingest.builder_common 29% 17% ❌
vxingest.ctc_to_cb 12% 1% ❌
vxingest.grib2_to_cb 12% 1% ❌
vxingest.netcdf_to_cb 13% 1% ❌
vxingest.partial_sums_to_cb 12% 1% ❌
vxingest.utilities 30% 32% ❌
Summary 16% (488 / 3015) 6% (40 / 700) ❌